bootstrap: stop one failed tool from killing the whole run
On a minimal Debian/RHEL image neither python3 nor unzip is present.
lib/fetch.sh's install_zip_bin needs one of them, so the 1Password CLI
install failed -- and under `set -eu` that killed bin/install.sh outright.
install_1p sits immediately before install_opencode and install_zarf, so
neither installed; bin/install.sh's non-zero exit then aborted bootstrap.sh,
so node/ (npx) and ansible/ (python3) never ran either.
Net effect on a fresh box: no opencode, no npx for the MCP servers, and no
python3 for model discovery. It presented as "opencode has no models or
skills". Reproduced in a clean debian:13 container.
Two fixes:
- bin/install.sh: each tool now installs via try(), which warns and
continues instead of aborting, and reports a summary of what failed. One
optional CLI is not worth the rest of the bootstrap. The subshell
re-enables set -e so a failed download can't fall through to mark_version
and stamp a version that was never installed.
- bootstrap.sh: ensure python3 before bin/ runs. It is a hard dependency,
not an extra -- lib/fetch.sh needs it (or unzip) for .zip assets, and
mcp-config/sync.sh needs it to inject discovered models.
Verified end to end on fresh debian:13: bootstrap completes, opencode/zarf/
op/npx/node/python3 all present, and opencode resolves all 3 covert-gpt
models.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -29,6 +29,20 @@ if [ ! -f "$SCRIPT_DIR/zsh/install.sh" ]; then
|
||||
exec "$DOTFILES_DIR/bootstrap.sh"
|
||||
fi
|
||||
|
||||
# python3 is a hard dependency of this setup, not an optional extra:
|
||||
# - lib/fetch.sh needs python3 (or unzip) to extract .zip release assets;
|
||||
# without either, the 1Password CLI install fails.
|
||||
# - mcp-config/sync.sh needs it to inject the gateway's discovered models;
|
||||
# without it opencode comes up with an EMPTY model list.
|
||||
# Minimal Debian/RHEL images ship neither python3 nor unzip, so install it
|
||||
# before bin/ runs. Non-fatal: an unsupported OS should degrade, not abort.
|
||||
if ! command -v python3 >/dev/null 2>&1 && ! command -v unzip >/dev/null 2>&1; then
|
||||
# shellcheck source=lib/os-detect.sh
|
||||
. "$SCRIPT_DIR/lib/os-detect.sh"
|
||||
echo "bootstrap: installing python3 (needed for zip assets and model discovery)"
|
||||
pkg_install python3 || echo "bootstrap: warning: could not install python3" >&2
|
||||
fi
|
||||
|
||||
"$SCRIPT_DIR/zsh/install.sh"
|
||||
"$SCRIPT_DIR/git/install.sh"
|
||||
# Runs before bin/ so the kind install gate can see the rootful daemon.
|
||||
|
||||
Reference in New Issue
Block a user